Fix bug due to empty ImagePullSecret #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set ImagePullSecret only if not empty. Ref: kubernetes/kubernetes#85332 Signed-off-by: Ritesh H Shukla <kerneltime@gmail.com>
dvaldivia
approved these changes
Jun 4, 2020
harshavardhana
approved these changes
Jun 4, 2020
|
@kerneltime Hey, cool to see this is already fixed, I've started working on this fix myself. The StatefulSet is not the only resource that has an image pull secret. So I think it would make sense to fix the rest as well. The affected areas are: KES StatefulSet: This PR is already merged, Shall we create a new one for this? |
|
Hi @stefanhenseler yes, feel free to send a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ImagePullSecret only if not empty.
Ref: kubernetes/kubernetes#85332
Signed-off-by: Ritesh H Shukla kerneltime@gmail.com